ref: Switch Hubs using a Guard #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 78.78% 78.70% -0.08%
==========================================
Files 76 77 +1
Lines 9266 9279 +13
==========================================
+ Hits 7300 7303 +3
- Misses 1966 1976 +10 |
Use a SwitchGuard internally as a replacement for `Hub::run` which does not require passing a closure, and does not go through `panic::catch_unwind`, as `Drop` impls are guaranteed to be executed even when panics are unwinding.
Swatinem
force-pushed
the
ref/hub-guard
branch
from
a931084 to
88a30a7
Compare
kamilogorek
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
SwitchGuardinternally as a replacement forHub::runwhich doesnot require passing a closure, and does not go through
panic::catch_unwind,as
Dropimpls are guaranteed to be executed even when panics are unwinding.fixes #522